-
Notifications
You must be signed in to change notification settings - Fork 977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update sl-jdbc.md #4604
Update sl-jdbc.md #4604
Conversation
We're making some changes to our API (not released yet), so I'm preemptively adding info.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, based on Paul's demo. I'm not sure when these features go live though.
Adding an example from Paul
copying the same over for jdbc -- maybe we can figure out a way to put this somewhere so we don't have to duplicate
timedimension is no longer optional
fixing some updates
fixing typo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM aside form comments
The ambiguous resolution stack has not been released yet, so do we need to wait for that to go out before merging this? |
making paul's reco's
paul's recos
also adding a dimension only example to it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks right to me. I think we need to add some more examples of how to query multi-hop dimensions in the CLI - but I can add that in a different PR.
@mirnawong1 this is ready to merge! |
double checked and looking great! merging 🚢 - thank you so much @rpourzand ! |
We're making some changes to our API (not released yet), so I'm preemptively adding info.
What are you changing in this pull request and why?
Checklist
Adding new pages (delete if not applicable):
website/sidebars.js
Removing or renaming existing pages (delete if not applicable):
website/sidebars.js
website/static/_redirects
npm run build
to update the links that point to the deleted page